Merged
Conversation
Member
|
We are relying on that for the tests. But you are correct, we should re-fator the tests and get rid of this file. I want to clean the HTML first before re-factoring the tests. There are many blank lines, whitespaces, etc. It creates a dirty and hard to edit HTML. |
Contributor
Author
|
@ocefpaf sounds like a good plan! |
Member
|
I'll fix the use of that in the code in another PR. Merging it. Thanks @birdage! |
ocefpaf
added a commit
to ocefpaf/folium
that referenced
this pull request
Aug 26, 2017
Merged
ocefpaf
added a commit
that referenced
this pull request
Aug 26, 2017
sanga
pushed a commit
to sanga/folium
that referenced
this pull request
Oct 24, 2017
sanga
pushed a commit
to sanga/folium
that referenced
this pull request
Oct 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ocefpaf we might not need the explicit src file, lets see how the build does