Skip to content

Fix #64: Remove margins from leaflet-tiles#65

Merged
ocefpaf merged 1 commit intopython-visualization:masterfrom
lennart0901:margin
Jan 1, 2015
Merged

Fix #64: Remove margins from leaflet-tiles#65
ocefpaf merged 1 commit intopython-visualization:masterfrom
lennart0901:margin

Conversation

@lennart0901
Copy link
Copy Markdown
Contributor

This fixes #64

@birdage
Copy link
Copy Markdown
Contributor

birdage commented Dec 29, 2014

@lennart0901 thx, ill wait for the build to pass

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented Dec 29, 2014

Thanks @lennart0901.

We do not have tests for the templates display (probably too difficult and
not essencial to the project). However, it would be nice to have images
showing before and after the change here in the PR thread.
Em 29/12/2014 14:49, "Andrew Bird" notifications@github.com escreveu:

@lennart0901 https://github.com/lennart0901 thx, ill wait for the build
to pass


Reply to this email directly or view it on GitHub
#65 (comment)
.

@lennart0901
Copy link
Copy Markdown
Contributor Author

Before patch
before

After patch:
after

ocefpaf added a commit that referenced this pull request Jan 1, 2015
Fix #64: Remove margins from leaflet-tiles
@ocefpaf ocefpaf merged commit 046e1a6 into python-visualization:master Jan 1, 2015
@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented Jan 1, 2015

@lennart0901 Thanks! Just one last request. Can you add that notebook to a gist (or something similar) so we can get a nbviewer URL. That way we can refer to it in the Changelog file.

@birdage BTW we should start a Changelog file!

@lennart0901
Copy link
Copy Markdown
Contributor Author

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented Jan 1, 2015

@lennart0901 thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tile alignment in ipython notebook

3 participants