Skip to content

Add HERE map tiles example#692

Merged
ocefpaf merged 1 commit intopython-visualization:masterfrom
deeplook:master
Aug 29, 2017
Merged

Add HERE map tiles example#692
ocefpaf merged 1 commit intopython-visualization:masterfrom
deeplook:master

Conversation

@deeplook
Copy link
Copy Markdown
Contributor

No description provided.

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented Aug 29, 2017

Cool use of ipywidgets there 👍

@deeplook
Copy link
Copy Markdown
Contributor Author

deeplook commented Aug 29, 2017

Seems like your Travis-CI failed, but I have no clue, why... Ah, ok, it was looking for the environment variables inside the notebook, which it cannot find, of course... Can you still merge it like this?

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented Aug 29, 2017

I guess this failure is expected 😄

AssertionError: Error: Environment variable HEREMAPS_APP_ID not found

To be honest most of the notebooks here belong in https://github.com/python-visualization/folium_contrib and not in this folder. Don't worry about it though.

Let me take this opportunity to finally "fix" the folium_contrib gallery and I'll move this notebook there along with the others.

@ocefpaf ocefpaf merged commit acdb340 into python-visualization:master Aug 29, 2017
@deeplook
Copy link
Copy Markdown
Contributor Author

Ok, sounds good!

sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants