popups allow unicode

[apatil]

Hi @ocefpaf, another small one. This allows unicode titles on popups.

[ocefpaf]

Hi @apatil we need to be smarter about this to ensure py3k compatibility.

Also, we will probably need something like:

'fancy string/unicode'.encode('ascii', 'xmlcharrefreplace')

To get a proper HTML representation.

Are you up to implement this? If not, can you open an issue and reference this PR?

[ocefpaf]

Use

isinstance(popup, (str, unicode))

instead.

[apatil]

Hi @ocefpaf, that's a good test suite. :) I'll give it a shot later today.

[apatil]

How does that look, @ocefpaf?

[ocefpaf]

Looking great @apatil! As a folium maintainer and a non-English speaker Thanks for doing this!!

I will review/test it and merge ASAP.

[ocefpaf]

@apatil I am on the fence here. I am not sure if the call to str is necessary, but it does not hurt... What is your argument?

[apatil]

I was getting type errors in python3 without it. The encode('ascii', ...) produces a bytes object, which json.dumps doesn't like.

[ocefpaf]

str it is then.

[ocefpaf]

@apatil I just finished review and it is looking really nice. Can you address the my raise request and squash the commits?

Also, can you add an entry in the Changelog.

(If you do not have time for that let me know and I will merge and do it myself 😉 )

[apatil]

@ocefpaf sorry for the delay and the extra commit, but it's mostly squashed. :)

[ocefpaf]

Nice! Thanks for sending another very useful PR!

[apatil]

My pleasure. :)