Add --insecure flag to CLI for wss:// connections #1683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an --insecure option to the CLI that allows connecting to wss:// endpoints with self-signed or invalid SSL certificates. This is useful for testing and development purposes. When --insecure is specified, the CLI creates an SSL context that disables certificate verification and hostname checking. Fixes python-websockets#1675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--insecureoption to the CLI that allows connecting to wss:// endpoints with self-signed or invalid SSL certificatesChanges
src/websockets/cli.pyto add--insecureargument--insecureis specified, the CLI creates an SSL context that disables certificate verification and hostname checkingTest plan
test_insecure_connection- verifies connection works with--insecureflagtest_insecure_connection_fails_without_flag- verifies connection fails without the flag when using self-signed certFixes #1675