Skip to content

Return 405 Method Not Allowed for non-GET HTTP requests #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
majiayu000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return 405 Method Not Allowed for non-GET HTTP requests #1684

majiayu000 wants to merge 1 commit into from
+99 −5

Conversation

@majiayu000
Copy link

@majiayu000 majiayu000 commented Dec 11, 2025

Summary

  • Return HTTP 405 Method Not Allowed for non-GET requests (HEAD, POST, etc.) instead of raising an exception
  • This reduces log noise from bots and crawlers hitting WebSocket endpoints

Changes

  • Added InvalidMethod exception to websockets.exceptions
  • Modified Request.parse() in http11.py to raise InvalidMethod instead of ValueError for unsupported methods
  • Updated ServerProtocol.parse() in server.py to catch InvalidMethod and return a proper 405 response with Allow: GET header
  • Updated tests to verify the new behavior

Test plan

  • Added tests for HEAD and POST requests returning 405
  • Updated existing tests to expect InvalidMethod instead of ValueError
  • All tests pass

Fixes #1677

@majiayu000
Return 405 Method Not Allowed for non-GET HTTP requests
af60bd4 
Instead of raising an exception when receiving HEAD, POST, or other
non-GET HTTP methods, the server now properly returns a 405 Method
Not Allowed response with an Allow: GET header.

This change:
- Adds InvalidMethod exception for unsupported HTTP methods
- Modifies Request.parse() to raise InvalidMethod instead of ValueError
- Handles InvalidMethod in ServerProtocol.parse() to return 405 response
- Updates tests accordingly

Fixes python-websockets#1677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HEAD raises an exception

1 participant

@majiayu000