Skip to content

fix: use proper URL parsing for GitHub API domain #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Apr 8, 2026
Merged

fix: use proper URL parsing for GitHub API domain #1039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/fromager/http_retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import random
import time
import typing
from urllib.parse import urlparse

import requests
from requests.adapters import HTTPAdapter
Expand Down Expand Up @@ -156,7 +157,7 @@ def send(
if (
response.status_code == 403
and request.url is not None
and "api.github.com" in request.url
and urlparse(request.url).hostname == "api.github.com"
and "rate limit" in response.text.lower()
):
self._handle_github_rate_limit(response, attempt, max_attempts)
Expand Down
Loading