docs: Add version-removed for resolve_source#1061
docs: Add version-removed for resolve_source#1061mergify[bot] merged 1 commit intopython-wheel-build:mainfrom
Conversation
Add a version removed entry to inform users that the `resolve_source` hook and `default_resolve_source` were removed. See 179c096 Signed-off-by: Christian Heimes <cheimes@redhat.com>
📝 WalkthroughWalkthroughDocumentation update to Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/reference/hooks.rst`:
- Around line 196-199: The documentation incorrectly states that resolve_source
and default_resolve_source were removed in 0.80.0 while the codebase still
defines resolve_source in src/fromager/sources.py; update the note to reflect
the current state by either removing the .. versionremoved:: 0.80.0 block or
changing it to a deprecation/compatibility note that explains resolve_source
still exists and points users to the newer resolver_provider hook; also replace
the ambiguous reference to "resolver_provider <resolver_provider_hook>" with the
actual callable name get_resolver_provider() so the doc matches the hook API
(mention resolve_source, default_resolve_source, get_resolver_provider, and
resolver_provider hook in the updated text).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c6c81771-0e46-4ce8-984b-19d45a5721d7
📒 Files selected for processing (1)
docs/reference/hooks.rst
Pull Request Description
What
Add a version removed entry to inform users that the
resolve_sourcehook anddefault_resolve_sourcewere removed.Why
See 179c096