Skip to content

tests: pass GITHUB_TOKEN to tests#1117

Merged
LalatenduMohanty merged 1 commit intopython-wheel-build:mainfrom
tiran:tests-github-token
May 6, 2026
Merged

tests: pass GITHUB_TOKEN to tests#1117
LalatenduMohanty merged 1 commit intopython-wheel-build:mainfrom
tiran:tests-github-token

Conversation

@tiran
Copy link
Copy Markdown
Collaborator

@tiran tiran commented May 6, 2026

Pull Request Description

What

Pass GITHUB_TOKEN secret to Fromager tests, GitHubTagResolver is able to use authenticated GitHub requests. The token permissions is already limited to contents read.

Why

Tests are running into GitHub API rate limiting issues.

Tests are running into GitHub API rate limiting issues. Pass
GITHUB_TOKEN secret to Fromager tests, `GitHubTagResolver` is able to
use authenticated GitHub requests. The token permissions is already
limited to contents read.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Warning

Rate limit exceeded

@tiran has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 40 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 95200121-74a6-4aea-a484-6bfe4cdff996

📥 Commits

Reviewing files that changed from the base of the PR and between abfdf97 and 74fdba1.

📒 Files selected for processing (1)
  • .github/workflows/test.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify Bot added the ci label May 6, 2026
@tiran
Copy link
Copy Markdown
Collaborator Author

tiran commented May 6, 2026

Experiment, I'm not sure this will actually work.

@tiran tiran marked this pull request as ready for review May 6, 2026 13:13
@tiran tiran requested a review from a team as a code owner May 6, 2026 13:13
@LalatenduMohanty
Copy link
Copy Markdown
Member

This might work. Looking in to more details.

@LalatenduMohanty LalatenduMohanty merged commit b5b31d9 into python-wheel-build:main May 6, 2026
39 checks passed
@LalatenduMohanty
Copy link
Copy Markdown
Member

LalatenduMohanty commented May 6, 2026

secrets.GITHUB_TOKEN won't be available for fork PRs. So it wont be able to fix the issue , but nevertheless it is an improvement.
This PR only helps PRs from branches within python-wheel-build/fromager itself .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants