Skip to content

tests: fix type annotation in test_pyproject#1133

Merged
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
tiran:pyproject-mypy
May 11, 2026
Merged

tests: fix type annotation in test_pyproject#1133
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
tiran:pyproject-mypy

Conversation

@tiran
Copy link
Copy Markdown
Collaborator

@tiran tiran commented May 11, 2026

Pull Request Description

What

Fix failing mypy check by using correct type annotatation in tests. The Container ABC does not include items().

tests/test_pyproject.py:48: error: "Container[Any]" has no attribute "items"  [attr-defined]

Fix failing mypy check by using correct type annotatation in tests. The
`Container` ABC does not include `items()`.

```
tests/test_pyproject.py:48: error: "Container[Any]" has no attribute "items"  [attr-defined]
```

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran requested a review from a team as a code owner May 11, 2026 14:51
@mergify mergify Bot added the ci label May 11, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Warning

Rate limit exceeded

@tiran has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 32 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5f59c5db-2bac-4c15-a703-a318e0449c51

📥 Commits

Reviewing files that changed from the base of the PR and between fd77c23 and 87a7aa9.

📒 Files selected for processing (1)
  • tests/test_pyproject.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tiran
Copy link
Copy Markdown
Collaborator Author

tiran commented May 11, 2026

@Mergifyio merge

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 11, 2026

merge

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@tiran tiran requested review from LalatenduMohanty and rd4398 May 11, 2026 15:07
Copy link
Copy Markdown
Contributor

@rd4398 rd4398 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiran tiran removed the request for review from LalatenduMohanty May 11, 2026 15:14
@mergify mergify Bot merged commit fbe65f7 into python-wheel-build:main May 11, 2026
39 checks passed
@tiran tiran deleted the pyproject-mypy branch May 11, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants