Skip to content

Conversation

@shubhbapna
Copy link
Contributor

fixes #118

If GITHUB_TOKEN is defined in the current environment then use it to create an authenticated instance of GitHub client and then use it in the resolver.

Copy link
Collaborator

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Could you please also update customization.md and mention the env var there? Thanks!

@dhellmann
Copy link
Member

Good work!

Could you please also update customization.md and mention the env var there? Thanks!

There's an authentication section in the REAMDE. That might be a better spot for docs.

@shubhbapna
Copy link
Contributor Author

Good work!
Could you please also update customization.md and mention the env var there? Thanks!

There's an authentication section in the REAMDE. That might be a better spot for docs.

Sorry I don't see an authentication section in the README

@dhellmann
Copy link
Member

Good work!
Could you please also update customization.md and mention the env var there? Thanks!

There's an authentication section in the REAMDE. That might be a better spot for docs.

Sorry I don't see an authentication section in the README

D'oh, that PR didn't merge, yet, sorry. #108

@shubhbapna
Copy link
Contributor Author

I wasn't sure if adding documentation for this would be right in Using private registries so I created another section which specifically states why a github token might be needed and how to pass it in Determining versions via GitHub tags

Let me know if that works @dhellmann @tiran

@shubhbapna shubhbapna requested a review from tiran July 3, 2024 18:57
Copy link
Member

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, thank you!

I'll leave this open for @tiran to re-review, since he had asked for changes.

@dhellmann dhellmann merged commit 1d7e36f into python-wheel-build:main Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add credentials for GitHub resolver

3 participants