document override functions related to building sdist #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhellmann
force-pushed
the
129-document-missing-override-function
branch
2 times, most recently
from
5d9ca26 to
019317d
Compare
Contributor
|
I don't know how important it is but "The |
We were missing docs for both get_build_sdist_dependencies() and build_sdist(). Fixes document the override for creating a source distribution python-wheel-build#129
dhellmann
force-pushed
the
129-document-missing-override-function
branch
from
019317d to
6c43f7b
Compare
Member
Author
Good catch, thanks! |
shubhbapna
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing docs for both get_build_sdist_dependencies() and build_sdist().
Fixes document the override for creating a source distribution #129