Skip to content

cleanup: fix typings for progress.py #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Aug 12, 2024
Merged

cleanup: fix typings for progress.py #297

mergify merged 1 commit into from
Aug 12, 2024

Conversation

@shubhbapna
Copy link
Contributor

@shubhbapna shubhbapna commented Aug 6, 2024

part of #226

fixes:

src/fromager/progress.py:10: error: Missing type parameters for generic type "tqdm"  [type-arg]
src/fromager/progress.py:27: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
src/fromager/progress.py:32: error: Missing type parameters for generic type "Iterable"  [type-arg]
src/fromager/progress.py:32: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
src/fromager/progress.py:40: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]

@shubhbapna shubhbapna requested a review from tiran August 6, 2024 18:59
@shubhbapna shubhbapna mentioned this pull request Aug 6, 2024
Open
38 tasks
tiran
tiran requested changes Aug 7, 2024
View reviewed changes
@shubhbapna shubhbapna requested a review from tiran August 7, 2024 14:39
@mergify mergify bot merged commit 4fe0930 into python-wheel-build:main Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shubhbapna @tiran