improve error messages from resolver #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhellmann
force-pushed
the
improve-resolver-error-messages
branch
from
c90abbc to
91097ce
Compare
Add better logging and exceptions in the resolver code to convey more information about what is happening when no match is found. Log info messages for cases like ignoring all candidate files or having no candidates at all. Use standard ResolverException error types and use messages specific to the different cases for searching for different types of files (sdists or wheels). Move all of the logic for checking version compatibility into is_satisified_by() method of the base class for more consistent logging via different paths.
dhellmann
force-pushed
the
improve-resolver-error-messages
branch
from
91097ce to
fce133c
Compare
Xaenalt
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add better logging and exceptions in the resolver code to convey more information about what is happening when no match is found.
Log debug messages for cases like ignoring all candidate files or having no candidates at all.
Use standard ResolverException error types and use messages specific to the different cases for searching for different types of files (sdists or wheels).
Move all of the logic for checking version compatibility into is_satisified_by() method of the base class for more consistent logging via different paths.