Fix: Pass config settings to hooks #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass `config_settings` to all hooks. This fixes sdist-only mode for `matplotlib`. The settings are now passed to `prepare_metadata_for_build_wheel` and meson no longer attempts to download freetype when getting build metadata. This change is backwards incompatible. `config_settings` is now a mapping of strings to list of strings. Before it was just a list of strings. I'm including my `e2e/matplotlib_settings` files for future testing. Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
pass-config-settings
branch
from
9a5ab75 to
9436558
Compare
dhellmann
reviewed
Jun 5, 2025
dhellmann
reviewed
Jun 5, 2025
Member
dhellmann
left a comment
dhellmann
left a comment
There was a problem hiding this comment.
This looks good. I will watch for you to remove the draft flag before approving, though, in case you have other changes coming.
Collaborator
Author
|
I have removed the draft flag. |
rd4398
reviewed
Jun 5, 2025
Contributor
There was a problem hiding this comment.
This looks good to me! I will wait for @dhellmann for final approval since he provided feedback earlier
dhellmann
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
config_settingsto all hooks. This fixes sdist-only mode formatplotlib. The settings are now passed toprepare_metadata_for_build_wheeland meson no longer attempts to download freetype when getting build metadata.This change is backwards incompatible.
config_settingsis now a mapping of strings to list of strings. Before it was just a list of strings.I'm including my
e2e/matplotlib_settingsfiles for future testing.