fix: use get_wheel_server_urls() in build command #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This PR refactors some code so bootstrap and build can shaer the same logic for wheel server urls. The bug could be fixed with a simpler change. |
The build commands like `build-sequence` were not using `pbi.wheel_server_url`. Under some conditions they were using wheels from an upstream server or requirement URL instead of the configured package wheel server. The `wheels.get_wheel_server_urls()` handles this case correctly, but the current implementation is not usable for build command. Refactor code: - modify `get_wheel_server_urls()` to accept a cache wheel server url instead of a hard-coded URL. - pass `cache_wheel_server_url` instead of `wheel_server_urls` in build commands - use `get_wheel_server_urls()` in build commands Fixes: python-wheel-build#704 Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
get_wheel_server_urls
branch
from
de5059c to
22299e2
Compare
dhellmann
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build commands like
build-sequencewere not usingpbi.wheel_server_url. Under some conditions they were using wheels from an upstream server or requirement URL instead of the configured package wheel server.The
wheels.get_wheel_server_urls()handles this case correctly, but the current implementation is not usable for build command.Refactor code:
get_wheel_server_urls()to accept a cache wheel server url instead of a hard-coded URL.cache_wheel_server_urlinstead ofwheel_server_urlsin build commandsget_wheel_server_urls()in build commandsFixes: #704