(refactor): Move caching from bootstrapper to resolver#941
Merged
rd4398 merged 1 commit intopython-wheel-build:mainfrom Mar 4, 2026
Merged
Conversation
Contributor
Author
|
The ticket for this is tracked downstream. |
dhellmann
reviewed
Feb 27, 2026
rd4398
force-pushed
the
refactor-move-cache-to-resolver
branch
from
472aef1 to
833dfbd
Compare
dhellmann
reviewed
Mar 2, 2026
dhellmann
reviewed
Mar 2, 2026
This commit improves cohesion by moving the session-level resolution cache
(_resolved_requirements) from Bootstrapper into RequirementResolver.
The cache now lives alongside the resolution logic it supports.
Changes:
- Added _resolved_requirements dict to RequirementResolver.__init__
- Updated resolve_source() and resolve_prebuilt() to check cache first
and update cache before returning
- Added cache_resolution() public method for externally-resolved git URLs
- Removed _resolved_requirements from Bootstrapper
- Updated Bootstrapper.resolve_version() to use resolver.cache_resolution()
for git URL results
This acts as next step towards implementing multiple version bootstrap
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Rohan Devasthale <rdevasth@redhat.com>
rd4398
force-pushed
the
refactor-move-cache-to-resolver
branch
from
f9f48f4 to
454b5a6
Compare
dhellmann
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves cohesion by moving the session-level resolution cache (_resolved_requirements) from Bootstrapper into RequirementResolver.
The cache now lives alongside the resolution logic it supports.
Changes:
This acts as next step towards implementing multiple version bootstrap