test: cap helper get_service_info timeout in suppression test (~3.0s → ~1.85s)#1708
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1708 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3426 3426
Branches 471 471
=======================================
Hits 3418 3418
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 17, 2026
20edf21 to
86464fb
Compare
…_by_question_history (~3.0s → ~1.85s) The helper thread calls `zc.get_service_info` with the default 3000ms timeout. Every query in this test is suppressed by the seeded question history, so no answer ever arrives — the helper sits at the timeout. The three phase waits in the main thread sum to ~2.06s, so capping the helper at 1500ms is safe and lets the test finish in the phase-wait budget instead of the helper budget. No production change.
86464fb to
2953144
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #1707. Tests-only change.
The helper thread in
test_get_info_suppressed_by_question_historycallszc.get_service_infowith the default 3000ms timeout. Every query in this test is suppressed by the seeded question history, so no answer ever arrives — the helper sits at the full timeout. The three phase waits in the main thread sum to ~2.06s, so capping the helper at 1500ms is safe and lets the test finish in the phase-wait budget instead of the helper-timeout budget.No production change.
Wall time:
Test plan
REQUIRE_CYTHON=1)tests/suite passes (337 passed, 3 IPv6 skips)