Skip to content

test: cap helper get_service_info timeout in suppression test (~3.0s → ~1.85s)#1708

Merged
bdraco merged 1 commit into
masterfrom
perf/tests-quick-question-suppression
May 18, 2026
Merged

test: cap helper get_service_info timeout in suppression test (~3.0s → ~1.85s)#1708
bdraco merged 1 commit into
masterfrom
perf/tests-quick-question-suppression

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 17, 2026

Summary

Part of #1707. Tests-only change.

The helper thread in test_get_info_suppressed_by_question_history calls zc.get_service_info with the default 3000ms timeout. Every query in this test is suppressed by the seeded question history, so no answer ever arrives — the helper sits at the full timeout. The three phase waits in the main thread sum to ~2.06s, so capping the helper at 1500ms is safe and lets the test finish in the phase-wait budget instead of the helper-timeout budget.

No production change.

Wall time:

  • Before: 3.01s
  • After: 1.85s

Test plan

  • Targeted test passes under Cython build (REQUIRE_CYTHON=1)
  • Full tests/ suite passes (337 passed, 3 IPv6 skips)
  • Pre-commit hooks pass

@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.76%. Comparing base (0deb56b) to head (2953144).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1708   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          33       33           
  Lines        3426     3426           
  Branches      471      471           
=======================================
  Hits         3418     3418           
  Misses          5        5           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 17, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing perf/tests-quick-question-suppression (2953144) with master (0deb56b)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (6db1f91) during the generation of this report, so 0deb56b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

…_by_question_history (~3.0s → ~1.85s)

The helper thread calls `zc.get_service_info` with the default 3000ms
timeout. Every query in this test is suppressed by the seeded
question history, so no answer ever arrives — the helper sits at the
timeout. The three phase waits in the main thread sum to ~2.06s, so
capping the helper at 1500ms is safe and lets the test finish in the
phase-wait budget instead of the helper budget.

No production change.
@bdraco bdraco force-pushed the perf/tests-quick-question-suppression branch from 86464fb to 2953144 Compare May 18, 2026 00:08
@bdraco bdraco changed the title test: speed up test_get_info_suppressed_by_question_history (~3.0s → ~1.5s) test: cap helper get_service_info timeout in suppression test (~3.0s → ~1.85s) May 18, 2026
@bdraco bdraco merged commit ee3c7d7 into master May 18, 2026
34 of 35 checks passed
@bdraco bdraco deleted the perf/tests-quick-question-suppression branch May 18, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant