test: fix race in test_register_and_lookup_type_by_uppercase_name#1712
Merged
Conversation
…e_by_uppercase_name
The cache-poll loop broke on `info.addresses` (A record) but the
next assertion checks `info.properties` (a separate TXT record
that arrives via its own cache update). On PyPy / skip_cython
the listener occasionally schedules the assertions between the
two, leaving `info.properties == {}`. Tighten the break condition
to require both before exiting the loop.
Hit on the PR #1710 CI run for pypy-3.10/ubuntu/skip_cython but the
race predates that PR and is not specific to it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1712 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3426 3426
Branches 471 471
=======================================
Hits 3418 3418
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_register_and_lookup_type_by_uppercase_namehas a long-standing race that surfaced on the PR #1710 CI run for the pypy-3.10 / ubuntu / skip_cython matrix entry. The cache-poll loop:breaks on the A record landing, but the next assertion checks the TXT record, which arrives via a separate cache update. Under PyPy / skip_cython the listener occasionally schedules the assertions between the two updates, leaving
info.properties == {}.Fix: require both before exiting the loop.
The race predates and is not specific to PR #1710 — same flakiness class hit a recent master run on a different test (
test_service_browser_expire_callbacks).Test plan