Rename handlers and internals to make it clear what is threadsafe#726
Merged
Merged
Conversation
- It was too easy to get confused about what was threadsafe and what was not threadsafe which lead to unexpected failures. Rename functions to make it clear what will be run in the event loop and what is expected to be threadsafe
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 98.16% 98.15% -0.01%
==========================================
Files 18 18
Lines 2174 2171 -3
Branches 378 377 -1
==========================================
- Hits 2134 2131 -3
Misses 25 25
Partials 15 15
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what was not threadsafe which lead to unexpected failures.
Rename functions to make it clear what will be run in the event
loop and what is expected to be threadsafe