Add tests for the DNSCache class#728
Merged
Merged
Conversation
- There is currently a bug in the implementation where an entry can exist in two places in the cache with different TTLs. Since a known answer cannot be both expired and expired at the same time, this is a bug that needs to be fixed.
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
==========================================
- Coverage 98.15% 97.88% -0.28%
==========================================
Files 18 18
Lines 2171 2171
Branches 377 377
==========================================
- Hits 2131 2125 -6
- Misses 25 29 +4
- Partials 15 17 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
can exist in two places in the cache with different TTLs. Since
a known answer cannot be both expired and expired at the same
time, this is a bug that needs to be fixed.