Simplify the can_send_to check#990
Merged
Merged
Conversation
Member
Author
|
|
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 2502 2502
Branches 408 408
=========================================
Hits 2502 2502
Continue to review full report at Codecov.
|
Member
Author
|
|
- There is no need to call can_send_to when we derive the target - can_send_to was converting the addr string into an ipaddress object to check if it was IPv4 or IPv6. Since this all happens internally there was no need for the additional validation and check. We can use a must more simple test.
bdraco
force-pushed
the
simplify_can_send_to
branch
from
2c23afe to
9df5203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to call can_send_to when we derive the target
since we already know we can send to it.
can_send_to was converting the addr string into an ipaddress object
to check if it was IPv4 or IPv6. Since this all happens internally there
was no need for the additional validation and check. We can use a must
more simple test.