Automatically generate the version number for docs#350
Merged
harlowja merged 2 commits intopython-zk:masterfrom Nov 13, 2015
Merged
Automatically generate the version number for docs#350harlowja merged 2 commits intopython-zk:masterfrom
harlowja merged 2 commits intopython-zk:masterfrom
Conversation
Reuse the code from setup.py to generate the proper version number for the Sphinx documentation.
Contributor
There was a problem hiding this comment.
I think in this code we can just do the following?
>>> from kazoo import version
...
The kazoo code is going to be needed to link the docs to the actually classes anyway, so I think we should be fine just importing it here (at least this is how I've commonly seen it done in other projects).
Contributor
Author
There was a problem hiding this comment.
Good catch, fixed in next commit.
deejay1
force-pushed
the
fix_sphinx_versioning
branch
from
176890e to
ef6718d
Compare
harlowja
added a commit
that referenced
this pull request
Nov 13, 2015
Automatically generate the version number for docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the code from setup.py to generate the proper version
number for the Sphinx documentation.