Fix handling of retry failures in Lock.acquire#358
Merged
harlowja merged 1 commit intopython-zk:masterfrom Feb 25, 2016
Merged
Conversation
(Fixes python-zk#288) - Make sure that self.node always exists. - Use _best_effort_cleanup() instead of _delete_node() when we didn't get the lock. - Make RetryFailedError use the existing cleanup code. - Make _best_effort_cleanup use self.node if it's set, and fall back to _find_node otherwise.
Contributor
|
👍 looks ok to me |
Contributor
Author
|
Can someone merge this, please? |
harlowja
added a commit
that referenced
this pull request
Feb 25, 2016
Fix handling of retry failures in Lock.acquire
Contributor
|
Merged ;) |
Contributor
Author
|
Great, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Fixes #288)
get the lock.
_find_node otherwise.