Manage session expirations with connection timeout#407
Closed
ralt wants to merge 1 commit intopython-zk:masterfrom
Closed
Manage session expirations with connection timeout#407ralt wants to merge 1 commit intopython-zk:masterfrom
ralt wants to merge 1 commit intopython-zk:masterfrom
Conversation
Before this change, kazoo is getting a TimeoutError (transformed into a ConnectionDropped error by the _socket_error_handling manager), which doesn't let the zk loop know that it should stop connecting, even long after the session has expired. It means that kazoo was forever looping, trying to get a new connection.
Contributor
Author
|
Sorry, this is against the ZK protocol as defined here: https://zookeeper.apache.org/doc/trunk/zookeeperProgrammers.html#ch_zkSessions Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, kazoo is getting a TimeoutError (transformed into a
ConnectionDropped error by the _socket_error_handling manager), which
doesn't let the zk loop know that it should stop connecting, even long
after the session has expired. It means that kazoo was forever looping,
trying to get a new connection.