Skip to content

Add dtrace worker tag support#754

Open
stratakis wants to merge 2 commits into
python:mainfrom
stratakis:even_more_minimal_dtrace
Open

Add dtrace worker tag support#754
stratakis wants to merge 2 commits into
python:mainfrom
stratakis:even_more_minimal_dtrace

Conversation

@stratakis

Copy link
Copy Markdown
Contributor

No description provided.

stratakis and others added 2 commits July 2, 2026 16:09
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how I'd do it. Maybe the branch logic could be elsewhere, but "dtrace is installed" is a feature of the worker, and I think tags are great for such features.

@encukou

encukou commented Jul 2, 2026

Copy link
Copy Markdown
Member

I generally want to move to using tags for configure options -- but mostly builder tags: e.g. having separate factories for Windows64PGONoGilTailcallBuild and all the other combinations of PGO/NoGil/Tailcall aren't a good use of subclassing.

Does that look like a good direction?

@encukou encukou requested a review from zware July 2, 2026 17:08
@stratakis

stratakis commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

I generally want to move to using tags for configure options -- but mostly builder tags: e.g. having separate factories for Windows64PGONoGilTailcallBuild and all the other combinations of PGO/NoGil/Tailcall aren't a good use of subclassing.

Does that look like a good direction?

For me it does sound that it;s a proper direction as it would reduce a lot of subclassing, given of course that an option to do extra customizations without much hassle will be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants