BUG: extend range for finding latest historical results#4
Merged
mattip merged 1 commit intopython:speed.pypy.orgfrom May 27, 2019
Merged
BUG: extend range for finding latest historical results#4mattip merged 1 commit intopython:speed.pypy.orgfrom
mattip merged 1 commit intopython:speed.pypy.orgfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives a little more headroom to transition "latest" to an active environment.
The problem is we would like to compare "latest" from the same environment as specified in
settings.DEF_ENVIRONMENT, but what happens if that environment is no longer active (as happens on speed.pypy.org where we have historical results from one machine but now run benchmarks on another). SinceRevisiondoes not specify an environment, we need to do aJOIN, which the code simulates by going back 100 results and then looking for a match