Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 21, 2023

(cherry picked from commit 47022a0)

Co-authored-by: David Lechner david@pybricks.com


📚 Documentation preview 📚: https://cpython-previews--108218.org.readthedocs.build/

(cherry picked from commit 47022a0)

Co-authored-by: David Lechner <david@pybricks.com>
@vstinner
Copy link
Member

Oh, Lint fails with:

Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst:2: default role used (hint: for inline literals, use double backticks) (default-role)
Misc/NEWS.d/next/Library/2023-08-17-14-45-25.gh-issue-105736.NJsH7r.rst:3: default role used (hint: for inline literals, use double backticks) (default-role)

Maybe rebasing the PR on up to date 3.12 may help? I don't know.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot

@bedevere-bot
Copy link

There's a new commit after the PR has been approved.

@vstinner: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from vstinner August 21, 2023 19:40
@miss-islington miss-islington deleted the backport-47022a0-3.12 branch August 21, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants