Skip to content

docs: fix grammar in isolating-extensions.rst #108037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2023
Merged

docs: fix grammar in isolating-extensions.rst #108037

merged 3 commits into from
Aug 21, 2023

Conversation

@dlech
Copy link
Contributor

@dlech dlech commented Aug 16, 2023 •
edited by github-actions bot
Loading

"is be attached" is not proper English. Guessing the original intention was "can be attached".

📚 Documentation preview 📚: https://cpython-previews--108037.org.readthedocs.build/

@dlech
docs: fix grammar in isolating-extensions.rst
77f509c 
"is be attached" is not proper English. Guessing the original intention was "can be attached".
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Aug 16, 2023
AA-Turner
AA-Turner reviewed Aug 20, 2023
View reviewed changes
@AA-Turner AA-Turner removed the request for review from serhiy-storchaka August 20, 2023 09:09
@dlech @AA-Turner
Update Doc/howto/isolating-extensions.rst
0c51109 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@vstinner
Copy link
Member

vstinner commented Aug 21, 2023

The Docs/Docs job failed with:

check-warnings.py: error: unrecognized arguments: --annotate-diff origin/main origin/dlech-patch-1

@vstinner
Copy link
Member

vstinner commented Aug 21, 2023

I updated the PR to the main branch to see if it fix the Docs/Docs CI.

@vstinner vstinner enabled auto-merge (squash) August 21, 2023 15:30
vstinner
vstinner approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 47022a0 into python:main Aug 21, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Aug 21, 2023

Thanks @dlech for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Aug 21, 2023

GH-108218 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2023
@dlech @miss-islington
docs: fix grammar in isolating-extensions.rst (pythonGH-108037)
73dca32 
(cherry picked from commit 47022a0)

Co-authored-by: David Lechner <david@pybricks.com>
@dlech dlech deleted the dlech-patch-1 branch August 21, 2023 15:42
Yhg1s pushed a commit that referenced this pull request Aug 21, 2023
@miss-islington @dlech
[3.12] docs: fix grammar in isolating-extensions.rst (GH-108037) (#10…
a27f18a 
…8218)

docs: fix grammar in isolating-extensions.rst (GH-108037)
(cherry picked from commit 47022a0)

Co-authored-by: David Lechner <david@pybricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

@encukou encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dlech @vstinner @miss-islington @bedevere-bot @AA-Turner