Fix mock_open docstring to use readline #11176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Friendly ping @mariocj89 @cjw296 |
Contributor
|
Thanks @tirkarthi for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
@cjw296: Please replace |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 20, 2018
(cherry picked from commit 71f82a2) Co-authored-by: Xtreak <tirkarthi@users.noreply.github.com>
|
GH-11266 is a backport of this pull request to the 3.7 branch. |
Member
Author
|
Thanks @cjw296 and @mariocj89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be
readlineinstead ofmethoddline. I think this is trivial and doesn't need a bpo and NEWS entry.