New warning: `‘_Py_stdlib_module_names’ defined but not used` in `Python/stdlib_module_names.h`

[sobolevn]

Bug report

This happens in all recent PRs, examples:

• https://github.com/python/cpython/pull/113835/files
• https://github.com/python/cpython/pull/113843/files

Linked PRs

• gh-113845: Fix a compiler warning in Python/suggestions.c #113949

[Eclips4]

Seems it's created for this PR: #113769
It's already used in Python/suggestions.c, so..

[serhiy-storchaka]

It was introduced by #110721. @pablogsal

[pablogsal]

As probably will be used in #113769 let's not remove yet.

[serhiy-storchaka]

#113769 does not touch Python/suggestions.c.

[pablogsal]

#113769 does not touch Python/suggestions.c.

No, but uses _Py_stdlib_module_names no?

[pablogsal]

Ah, sorry, this is because we are #include "stdlib_module_names.h" // _Py_stdlib_module_names in suggestions.c. Right, I will create a PR removing the include 👍

[vstinner]

Currently, _Py_DumpExtensionModules() iterates on sys.stdlib_module_names with complicated code. Maybe it should just reuse _Py_stdlib_module_names list of C bytes strings.

Maybe static const char* _Py_stdlib_module_names[] = { should not be static, and exposed in pycore_sysmodule.h?