gh-116858: Add @cpython_only to several tests in test_cmd_line#116859
gh-116858: Add @cpython_only to several tests in test_cmd_line#116859sobolevn merged 1 commit intopython:mainfrom
@cpython_only to several tests in test_cmd_line#116859Conversation
|
Thank you! This is helpful! |
|
I have some experience in "porting" tests from CPython to RustPython and this PR seems great! Thanks, Nikita. |
|
Also, I would like to backport these changes to 3.11 & 3.12 branches. What do you think about this, Nikita? |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @sobolevn, I could not cleanly backport this to |
|
Sorry, @sobolevn, I could not cleanly backport this to |
|
I will do the backports manually! 👍 |
|
GH-116889 is a backport of this pull request to the 3.12 branch. |
|
GH-116890 is a backport of this pull request to the 3.11 branch. |
List of tests and reasoning:
test_help,test_help_env,test_help_xoptions,test_help_allmake assumptions about the exact output of help, which might not be the case for other implementations. They can show help as tables / with-Xprefix, or whatevertest_versionexplicitly tests that it starts withPython(it might beRustPythonfor other implementaions)test_env_var_frozen_modulesandtest_xoption_frozen_modulesuses frozenmodules, which a basically our internal implementation detail that uses C partstest_unknown_optionsexpects a very specific error messagetest_xdevusesmallocchecks insideCC @youknowone from RustPython, it might be interesting to you.
test_cmd_lineascpython_only#116858