Skip to content

Conversation

@chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented Nov 28, 2025

Skipping .debug$S COFF sections fixes this.

@chris-eibl chris-eibl changed the title GH-142050: Jit stencils on Windows contain debug data on Windows GH-142050: Jit stencils on Windows contain debug data Nov 28, 2025
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for noticing this. Do you think this happened on 3.14 as well?

@chris-eibl
Copy link
Member Author

No, as written in the issue I haven't seen that on 3.14. Neither on main for Linux in WSL.

I also haven't looked on ARM or Win32, yet.

A second pair of eyes can't hurt!

I think on 3.14 we're safe since no big changes will happen there anymore?

OTOH, the change is simple and small so better safe than sorry and backport?

There are other sections we might want to skip, maybe on other platforms, too.

But we can add them on a case-by-case basis when they start to hurt us ...

@savannahostrowski
Copy link
Member

Oops, I think my review comment got eaten by GitHub?

In any case, thanks for this!

I'm +1 on handling other debug section types on a case-by-case basis. I'd rather know that these have started appearing and understand why, rather than silently ignore them.

I probably wouldn't advocate for a backport either, FWIW...unless we know this is happening in 3.14.

@savannahostrowski savannahostrowski enabled auto-merge (squash) December 3, 2025 21:43
@savannahostrowski savannahostrowski merged commit 618dc36 into python:main Dec 3, 2025
72 checks passed
@chris-eibl chris-eibl deleted the shrink-stencils branch December 4, 2025 18:09
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
…42052)

Co-authored-by: Savannah Ostrowski <savannah@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants