GH-142050: Jit stencils on Windows contain debug data #142052
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-eibl
requested review from
brandtbucher,
diegorusso and
savannahostrowski
as code owners
chris-eibl
changed the title
Fidget-Spinner
approved these changes
Nov 28, 2025
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Oops, thanks for noticing this. Do you think this happened on 3.14 as well?
Member
Author
|
No, as written in the issue I haven't seen that on 3.14. Neither on main for Linux in WSL. I also haven't looked on ARM or Win32, yet. A second pair of eyes can't hurt! I think on 3.14 we're safe since no big changes will happen there anymore? OTOH, the change is simple and small so better safe than sorry and backport? There are other sections we might want to skip, maybe on other platforms, too. But we can add them on a case-by-case basis when they start to hurt us ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping
.debug$SCOFF sections fixes this.