Vary compiler flags in fuzz_pycompile#145236
Merged
alex merged 2 commits intopython:mainfrom Mar 9, 2026
Merged
Conversation
alex
reviewed
Mar 9, 2026
| // Use third byte to determine compiler flags to use. | ||
| unsigned char flags_byte = (unsigned char) data[2]; | ||
| PyCompilerFlags flags = _PyCompilerFlags_INIT; | ||
| if (flags_byte & 0x01) { |
Member
There was a problem hiding this comment.
I'm not sure all of these are useful/make sense.
I don't think PyCF_SOURCE_IS_UTF8 does anything, for example. So I'd drop that and PyCF_ONLY_AST,
Member
Author
There was a problem hiding this comment.
I can drop PyCF_SOURCE_IS_UTF8, but PyCF_ONLY_AST does change quite a lot.
alex
approved these changes
Mar 9, 2026
Member
Author
|
Thanks for the review ❤️ |
Member
|
Thanks for working on this! |
Member
Author
|
This already found its first bug in the parser! Not even a day after its implementation: #145783 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements an old todo suggestion.