Skip to content

bpo-37256: Wording in Request class docs #14792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2019
Merged

bpo-37256: Wording in Request class docs #14792

merged 3 commits into from
Aug 14, 2019

Conversation

@nsiregar
Copy link
Contributor

@nsiregar nsiregar commented Jul 16, 2019 •
edited by bedevere-bot
Loading

change wording in Request class documentation

https://bugs.python.org/issue37256

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 16, 2019
aeros
aeros approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@aeros aeros left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsiregar Welcome and thanks for the contribution!

I definitely agree with the suggested changes. Since there are three additional arguments, it should be "next" instead of "last".

However, I would recommend making a small adjustment to the phrasing of the news entry to specify the module of the class, and use reST (markup language used by python docs):

@nsiregar @aeros
Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.q…
fb494d4 
…JTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
CuriousLearner
CuriousLearner approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@CuriousLearner CuriousLearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice catch! 💯

LGTM 🌮

Thank you for your contribution @nsiregar

@CuriousLearner
Copy link
Member

CuriousLearner commented Aug 13, 2019

Hiya @Mariatta @orsenthil

Can you please have a look at this one?

Thanks!

orsenthil
orsenthil approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sanyam.

@orsenthil orsenthil merged commit 38c7199 into python:master Aug 14, 2019
@bedevere-bot
Copy link

bedevere-bot commented Aug 14, 2019

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Aug 14, 2019

Thanks @nsiregar for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Aug 14, 2019

Thanks @nsiregar for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Aug 14, 2019

GH-15277 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2019
@nsiregar @miss-islington
bpo-37256: Wording in Request class docs (pythonGH-14792)
c9ecd3a 
* bpo-37256: Wording in Request class docs

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.qJTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit 38c7199)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2019
@nsiregar @miss-islington
bpo-37256: Wording in Request class docs (pythonGH-14792)
62a558a 
* bpo-37256: Wording in Request class docs

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.qJTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit 38c7199)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 14, 2019

GH-15278 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Aug 14, 2019
@miss-islington @nsiregar
bpo-37256: Wording in Request class docs (GH-14792)
3e1f135 
* bpo-37256: Wording in Request class docs

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.qJTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit 38c7199)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>
miss-islington added a commit that referenced this pull request Aug 16, 2019
@miss-islington @nsiregar
bpo-37256: Wording in Request class docs (GH-14792)
f991912 
* bpo-37256: Wording in Request class docs

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.qJTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit 38c7199)

Co-authored-by: Ngalim Siregar <ngalim.siregar@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@nsiregar @aeros @lisroach
bpo-37256: Wording in Request class docs (python#14792)
786dbba 
* bpo-37256: Wording in Request class docs

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.qJTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@nsiregar @aeros @DinoV
bpo-37256: Wording in Request class docs (python#14792)
be0e2dc 
* bpo-37256: Wording in Request class docs

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.qJTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@nsiregar @aeros @websurfer5
bpo-37256: Wording in Request class docs (python#14792)
0e7155c 
* bpo-37256: Wording in Request class docs

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Documentation/2019-07-16-14-48-12.bpo-37256.qJTrBb.rst

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil orsenthil approved these changes

@CuriousLearner CuriousLearner CuriousLearner approved these changes

+2 more reviewers

@mangrisano mangrisano mangrisano approved these changes

@aeros aeros aeros approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nsiregar @CuriousLearner @bedevere-bot @miss-islington @orsenthil @mangrisano @aeros @the-knights-who-say-ni