Skip to content

bpo-41891: ensure asyncio.wait_for waits for task completion #22461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1st1 merged 3 commits into from
Dec 18, 2020
Merged

bpo-41891: ensure asyncio.wait_for waits for task completion #22461

1st1 merged 3 commits into from
Dec 18, 2020

Conversation

@rkojedzinszky
Copy link
Contributor

@rkojedzinszky rkojedzinszky commented Sep 30, 2020 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Sep 30, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@rkojedzinszky

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@1st1
Copy link
Member

1st1 commented Oct 1, 2020

@elprans please take a look. You've been fixing wait_for for quite some time.

@elprans
Copy link
Contributor

elprans commented Oct 1, 2020

The fix looks good to me. Needs a test, though.

@rkojedzinszky
bpo-41891: test cases for wait_for to behave consistently.
96564c6 
asyncio.wait_for should wait for the future to terminate in all cases.
1st1
1st1 reviewed Oct 1, 2020
View reviewed changes
@1st1 1st1 merged commit 17ef431 into python:master Dec 18, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Dec 18, 2020

Thanks @rkojedzinszky for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Dec 18, 2020

@1st1: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 18, 2020
@rkojedzinszky @miss-islington
bpo-41891: ensure asyncio.wait_for waits for task completion (pythonG…
3570037 
…H-22461)

(cherry picked from commit 17ef431)

Co-authored-by: Richard Kojedzinszky <rkojedzinszky@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 18, 2020

GH-23840 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 18, 2020
@rkojedzinszky @miss-islington
bpo-41891: ensure asyncio.wait_for waits for task completion (pythonG…
f93848f 
…H-22461)

(cherry picked from commit 17ef431)

Co-authored-by: Richard Kojedzinszky <rkojedzinszky@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 18, 2020

GH-23841 is a backport of this pull request to the 3.8 branch.

@1st1 1st1 mentioned this pull request Dec 18, 2020
Closed
miss-islington added a commit that referenced this pull request Dec 18, 2020
@miss-islington @rkojedzinszky
bpo-41891: ensure asyncio.wait_for waits for task completion (GH-22461)
a3dec9d 
(cherry picked from commit 17ef431)

Co-authored-by: Richard Kojedzinszky <rkojedzinszky@users.noreply.github.com>
1st1 pushed a commit that referenced this pull request Dec 18, 2020
@miss-islington @rkojedzinszky
bpo-41891: ensure asyncio.wait_for waits for task completion (GH-22461)…
82dbfd5 
… (#23840)

(cherry picked from commit 17ef431)

Co-authored-by: Richard Kojedzinszky <rkojedzinszky@users.noreply.github.com>

Co-authored-by: Richard Kojedzinszky <rkojedzinszky@users.noreply.github.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@rkojedzinszky @adorilson
bpo-41891: ensure asyncio.wait_for waits for task completion (python#…
f5051a7 
…22461)
@rkojedzinszky rkojedzinszky deleted the fix-issue-41891 branch January 11, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rkojedzinszky @the-knights-who-say-ni @1st1 @elprans @miss-islington @bedevere-bot