BaseHTTPRequestHandler, that path includes query#25597
Merged
orsenthil merged 2 commits intopython:masterfrom Apr 25, 2021
orsenthil:address_gh_16884
Merged
BaseHTTPRequestHandler, that path includes query#25597orsenthil merged 2 commits intopython:masterfrom orsenthil:address_gh_16884
orsenthil merged 2 commits intopython:masterfrom
orsenthil:address_gh_16884
Conversation
Fidget-Spinner
approved these changes
Apr 25, 2021
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
LGTM. I think this reads well.
|
@orsenthil: Please replace |
Contributor
|
Thanks @orsenthil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 25, 2021
* Clarify, for BaseHTTPRequestHandler, that path includes query Co-authored-by: David Jones <drj@pobox.com> (cherry picked from commit a89d8a9) Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
|
GH-25598 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 25, 2021
* Clarify, for BaseHTTPRequestHandler, that path includes query Co-authored-by: David Jones <drj@pobox.com> (cherry picked from commit a89d8a9) Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
|
GH-25599 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Apr 25, 2021
* Clarify, for BaseHTTPRequestHandler, that path includes query Co-authored-by: David Jones <drj@pobox.com> (cherry picked from commit a89d8a9) Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
miss-islington
added a commit
that referenced
this pull request
Apr 25, 2021
* Clarify, for BaseHTTPRequestHandler, that path includes query Co-authored-by: David Jones <drj@pobox.com> (cherry picked from commit a89d8a9) Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the changes requested in #16884