Skip to content

Clarify, for BaseHTTPRequestHandler, that path includes query#16884

Closed
drj11 wants to merge 1 commit intopython:masterfrom
drj11:drj11/path
Closed

Clarify, for BaseHTTPRequestHandler, that path includes query#16884
drj11 wants to merge 1 commit intopython:masterfrom
drj11:drj11/path

Conversation

@drj11
Copy link
Copy Markdown
Contributor

@drj11 drj11 commented Oct 22, 2019

A minor improvement to the documentation for BaseHTTPRequestHandler in the http.server library.
Pointing that the path attribute also includes the query part, when present.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 22, 2019
@drj11
Copy link
Copy Markdown
Contributor Author

drj11 commented Oct 30, 2019

Can someone please add skip label and skip news? Thanks!

@csabella csabella requested a review from orsenthil January 11, 2020 00:26
orsenthil
orsenthil requested changes Jan 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good to me. Please make sure to format it at 80 column wrap for better readability.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jan 11, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Copy link
Copy Markdown
Contributor

csabella commented May 28, 2020

@drj11, please make the requested changes. Thanks!

@orsenthil orsenthil mentioned this pull request Apr 25, 2021
Merged
@orsenthil
Copy link
Copy Markdown
Member

orsenthil commented Apr 25, 2021

Superseded by #25597

@orsenthil orsenthil closed this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil orsenthil requested changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@drj11 @bedevere-bot @csabella @orsenthil @eamanu @the-knights-who-say-ni