Skip to content

[3.9] bpo-43207: InspectLoader.is_package is not an abstract method (GH-24517) #26322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

[3.9] bpo-43207: InspectLoader.is_package is not an abstract method (GH-24517) #26322

merged 1 commit into from
Jul 12, 2021

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 23, 2021 •
edited
Loading

Making the description of InspectLoader.is_package aligned with the current implementation.

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit 8b9310d)

Co-authored-by: Junnosuke Kuroda Isa-rentacs@users.noreply.github.com

https://bugs.python.org/issue43207

Automerge-Triggered-By: GH:jaraco

@Isa-rentacs @miss-islington
bpo-43207: InspectLoader.is_package is not an abstract method (python…
beefbf1 
…GH-24517)

Making the description of `InspectLoader.is_package` aligned with the current implementation.

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit 8b9310d)

Co-authored-by: Junnosuke Kuroda <Isa-rentacs@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this pull request May 23, 2021
Merged
@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir awaiting review labels May 23, 2021
@miss-islington
Copy link
Contributor Author

miss-islington commented May 23, 2021

@Isa-rentacs: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

miss-islington commented May 23, 2021

@Isa-rentacs: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented May 23, 2021

@miss-islington: Status check is done, and it's a success ✅ .

@FFY00
Copy link
Member

FFY00 commented May 30, 2021

@jaraco ping. I don't understand why the merge did not trigger.

@github-actions
Copy link

github-actions bot commented Jun 30, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 30, 2021
@ambv ambv merged commit 779983e into python:3.9 Jul 12, 2021
@bedevere-bot
Copy link

bedevere-bot commented Jul 12, 2021

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington miss-islington deleted the backport-8b9310d-3.9 branch July 12, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@miss-islington @FFY00 @bedevere-bot @jaraco @ambv @the-knights-who-say-ni @Isa-rentacs