Implementation of chomp() on string objects.

[bjornpettersen]

BPO	403029
Nosy	@gvanrossum
Files	None: None

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2001-01-01.17:47:23.000>
created_at = <Date 2000-12-28.05:50:24.000>
labels = ['interpreter-core']
title = 'Implementation of chomp() on string objects.'
updated_at = <Date 2001-01-01.17:47:23.000>
user = 'https://bugs.python.org/bjornpettersen'

bugs.python.org fields:

activity = <Date 2001-01-01.17:47:23.000>
actor = 'gvanrossum'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2000-12-28.05:50:24.000>
creator = 'bjorn_pettersen'
dependencies = []
files = ['2985']
hgrepos = []
issue_num = 403029
keywords = ['patch']
message_count = 5.0
messages = ['35148', '35149', '35150', '35151', '35152']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'bjorn_pettersen']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue403029'
versions = []

[bjornpettersen]

The chomp() method removes a single line terminator if present, and handles unix, dos, and mac line
endings intelligently.

[gvanrossum]

Hm. s.rstrip() does the same thing (plus strips trailing whitespace, which is rarely a problem). Do you really need this function? If so, please don't call it chomp() -- that's a Perl-ism that makes no sense to anyone else.

*If* (and I say *if*) this is accepted, we would require a Unicode version and documentation as well.

[gvanrossum]

Rejecting this now. Comments on python-dev are mostly negative.

Note that there's also splitlines().

[bjornpettersen]

It was almost universally felt (on c.l.py) that a method doing this would be a good idea (since rstrip does too much, and splitlines() would be rather cryptic when used in the common "while 1:" idiom -- not to mention that the common "line = line[:-1]" is completely wrong).

Naming was an issue. I don't do Perl, but even I know what chomp is after a dozen or so requests on c.l.py. Perhaps rmLineTerm() or some such would be better?

If this is reconsidered, I'd be glad to implement a patch for both the unicode string and the documentation.

[gvanrossum]

I don't typically have the time to follow c.l.py anymore, so I wasn't aware of that. Would you mind pointing me to the discussion (a Deja.com URL would be dandy)?

Your suggestion of rmLineTerm() for the method name suggests that you haven't done Python for very long either. Compare the other string method names.

There's also the issue of why bother stripping \r and \r\n; if you're reading using f.readline(), these would already have been converted to \n.