win32 build_ext problem

[jhylton]

BPO	614051
Nosy	@theller

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/theller'
closed_at = <Date 2002-11-04.08:22:20.000>
created_at = <Date 2002-09-24.21:18:31.000>
labels = ['library']
title = 'win32 build_ext problem'
updated_at = <Date 2002-11-04.08:22:20.000>
user = 'https://bugs.python.org/jhylton'

bugs.python.org fields:

activity = <Date 2002-11-04.08:22:20.000>
actor = 'theller'
assignee = 'theller'
closed = True
closed_date = None
closer = None
components = ['Distutils']
creation = <Date 2002-09-24.21:18:31.000>
creator = 'jhylton'
dependencies = []
files = []
hgrepos = []
issue_num = 614051
keywords = []
message_count = 3.0
messages = ['12471', '12472', '12473']
nosy_count = 2.0
nosy_names = ['jhylton', 'theller']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue614051'
versions = []

[jhylton]

From: Andy Miller <amiller@juniper.net>
To: jeremy@alum.mit.edu
Subject: Bug in build_ext.py
Date: Tue, 10 Sep 2002 03:25:46 -0700

In the last CVS version of build_ext.py you changed the
get_libraries function to read:

  if sys.platform == "win32":
     from distutils.msvccompiler import MSVCCompiler
     if not isinstance(self.compiler, MSVCCompiler):
         template = "python%d%d"

It also needs an else assocated with the "if not
isinstance"
else:
return ext.libraries

Otherwise if an installer has defined their own
compiler (or is
not using MSVC I suppose) then none of the libraries are
passed to the link stage - I discovered this with the
WxPython modules. The previous version of build_ext used
to fallout the bottom with the "return ext.libraries"
while with
the current version you get a 'None' if Win32 and NOT MSVC

Cheers

Andy

[theller]

Logged In: YES
user_id=11105

I've checked in a patch: build_ext.py, rev 1.86.

[theller]

Logged In: YES
user_id=11105

Closing as fixed.