Compatibility changes for _strptime.py

[brettcannon]

BPO	670012
Nosy	@tim-one, @brettcannon
Files	compat.diff: 2003-01-17: cvs diff -u from src/

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tim-one'
closed_at = <Date 2003-01-18.03:57:35.000>
created_at = <Date 2003-01-17.22:03:21.000>
labels = ['library']
title = 'Compatibility changes for _strptime.py'
updated_at = <Date 2003-01-18.03:57:35.000>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2003-01-18.03:57:35.000>
actor = 'tim.peters'
assignee = 'tim.peters'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2003-01-17.22:03:21.000>
creator = 'brett.cannon'
dependencies = []
files = ['4930']
hgrepos = []
issue_num = 670012
keywords = ['patch']
message_count = 2.0
messages = ['42452', '42453']
nosy_count = 2.0
nosy_names = ['tim.peters', 'brett.cannon']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue670012'
versions = ['Python 2.3']

[brettcannon]

This patch has a few compatibility changes so as to be a better drop-in replacement for the C version. First, the 'y' directive now handles [00, 68] as a suffix for the 21st century while [69, 99] is treated as the suffix for the 20th century (this is for Open Group compatibility). strptime now returns default values that make it a valid date (this is in response to Kevin Jacobs' discovery that default values of -1 might thow someone off if they use time.mktime(); thread on this can be found at http://mail.python.org/pipermail/python-dev/2003-January/031983.html). Lastly, the ability to pass in a regex object to use instead of a format string (and the inverse ability to have strptime return a regex object) has been removed. This is in preparation for a future patch that will add some caching internally to get a speed boost.

test_strptime.py has some tests added and removed. Also did a minute amount of nit-picky changes. Some of the changes should have gone in when _strptime.py hit 1.9 in CVS, but I forgot to include them in the patch; sorry about that.

[tim-one]

Logged In: YES
user_id=31435

Thanks, Brett! Checked in:

Lib/_strptime.py; new revision: 1.10
Lib/test/test_strptime.py; new revision: 1.9