Simple File fix for Windows Runtime incompatability

[mdjeremy]

BPO	1003535
Nosy	@tim-one, @loewis, @tiran
Files	win_runtime_patch_c.diff: Context diff of the two changes

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2008-01-20.19:24:02.916>
created_at = <Date 2004-08-04.20:17:51.000>
labels = ['interpreter-core']
title = 'Simple File fix for Windows Runtime incompatability'
updated_at = <Date 2008-01-20.19:24:02.914>
user = 'https://bugs.python.org/mdjeremy'

bugs.python.org fields:

activity = <Date 2008-01-20.19:24:02.914>
actor = 'christian.heimes'
assignee = 'none'
closed = True
closed_date = <Date 2008-01-20.19:24:02.916>
closer = 'christian.heimes'
components = ['Interpreter Core']
creation = <Date 2004-08-04.20:17:51.000>
creator = 'mdjeremy'
dependencies = []
files = ['6136']
hgrepos = []
issue_num = 1003535
keywords = ['patch']
message_count = 4.0
messages = ['46526', '46527', '46528', '61340']
nosy_count = 4.0
nosy_names = ['tim.peters', 'loewis', 'christian.heimes', 'mdjeremy']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1003535'
versions = ['Python 2.3']

[mdjeremy]

Problem:

PyRun_SimpleFile - Using this function on Windows with
MSVC7 (VS .NET) causes a crash.

Reason:

1)Pre built binaries link to msvcrt.dll. New version of
MSVC link to msvcrt71.dll. The FILE structure is
different across the two versions of runtime library.

2. If python23.dll is rebuilt using the latest binary,
   and issue exist where passing in FILE * still causes
   the runtime library to throw an exception due to
   running in the dll's context.

Solution:

Remove both of these problems by adding a new function
that only takes the filename (future maybe fopen flags)
and have the dll open the file itself and pass it on.

New function added to pythonrun.c and pythonrun.h

int
PyRun_SimpleFileWithOpen(const char *filename)

Takes just the file name, opens the file and then pass
it on.

[tim-one]

Logged In: YES
user_id=31435

There appear to be all sorts of things in the patch that don't
have anything to do with the new function. Is that
intentional?

[loewis]

Logged In: YES
user_id=21627

I would like to see the following changes to the patch:

• remove all parts that are not strictly relevant (IOW, make
  it minimal)
• call the function PyRun_SimpleFileName
• Add a PyCompilerFlags*. If you want to, you can allow this
  argument to be NULL.
• Add a PyRun_SimpleParseFileName parallel function, and
  PyRun_FileName
  (i.e. all File APIs except for Any, which supports
  terminals and is irrelevant here)
• Provide documentation patches as well.

Are you willing to carry out these changes?

[tiran]

We are using VS 2008 now and we don't support mixing multiple CRTs. If
you still want to get your patch into Python 2.6 create a new issue with
a clean patch.