Add IEEE Float support to wave.py

[bensatmitedu]

BPO	1144504
Nosy	@loewis, @akuchling
Superseder	bpo-16525: wave file module does not support 32bit float format
Files	wave.patch: a patch for wave.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-11-22.01:09:29.700>
created_at = <Date 2005-02-19.20:02:45.000>
labels = ['extension-modules']
title = 'Add IEEE Float support to wave.py'
updated_at = <Date 2012-11-22.01:09:29.700>
user = 'https://bugs.python.org/bensatmitedu'

bugs.python.org fields:

activity = <Date 2012-11-22.01:09:29.700>
actor = 'jcea'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Extension Modules']
creation = <Date 2005-02-19.20:02:45.000>
creator = 'bensatmit_edu'
dependencies = []
files = ['6507']
hgrepos = []
issue_num = 1144504
keywords = ['patch']
message_count = 5.0
messages = ['47812', '47813', '47814', '47815', '137020']
nosy_count = 5.0
nosy_names = ['loewis', 'akuchling', 'mcherm', 'bensatmit_edu', 'bemasc']
pr_nums = []
priority = 'normal'
resolution = 'rejected'
stage = None
status = 'closed'
superseder = '16525'
type = None
url = 'https://bugs.python.org/issue1144504'
versions = ['Python 2.3']

[bensatmitedu]

IEEE Float .wav files have almost identical structure
to standard PCM .wav files. Currently, wave.py gives
an unknown format error when attempting to read IEEE
Float .wav files. This patch causes wave.py to read
those files properly.

No changes were made to wave_write, only wave_read.

[mcherm]

Logged In: YES
user_id=99874

I don't know anything about the .wav format, but the patch
is particularly inoffensive... it simply allows a second
format constant in the WAVE header without raising an error.
I recomend applying the patch as soon as someone else who
DOES know the .wav format can confirm that it's being done
right.

[akuchling]

Logged In: YES
user_id=11375

Looking at the WAV format description at
http://ccrma.stanford.edu/CCRMA/Courses/422/projects/WaveFormat
, it looks like the patch isn't correct. There's an
ExtraParams field after the header that's only present if
the format is not PCM. If this is correct, the patch should
also add code to read this field and either store it
somewhere or just discard it.

[loewis]

Since there was no follow-up to Andrew's remark that the patch is incorrect, I conclude that the submitter either lost interest in it, or agrees that the patch is indeed incorrect. Rejecting it as invalid.

[bemasc]

I am the original author ... just ran into the same exact issue 6 years later, and google turned up this ticket. This bug is still unfixed, and the patch is still correct. The patch does not reject any valid WAV files. Its worst sin is accepting and processing (correctly) some technically invalid files, which I would argue is actually desirable behavior.