ConfigParser alternative key-value delimitier

[fidoman]

BPO	1165404
Nosy	@devdanzin
Superseder	bpo-1682942: ConfigParser support for alt delimiters
Files	ConfigParser.diff: diff file

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2009-02-16.03:13:43.111>
created_at = <Date 2005-03-17.16:57:04.000>
labels = ['type-feature', 'library']
title = 'ConfigParser alternative key-value delimitier'
updated_at = <Date 2009-02-16.03:13:43.110>
user = 'https://bugs.python.org/fidoman'

bugs.python.org fields:

activity = <Date 2009-02-16.03:13:43.110>
actor = 'ajaksu2'
assignee = 'none'
closed = True
closed_date = <Date 2009-02-16.03:13:43.111>
closer = 'ajaksu2'
components = ['Library (Lib)']
creation = <Date 2005-03-17.16:57:04.000>
creator = 'fidoman'
dependencies = []
files = ['6549']
hgrepos = []
issue_num = 1165404
keywords = ['patch']
message_count = 5.0
messages = ['47990', '47991', '47992', '47993', '82180']
nosy_count = 4.0
nosy_names = ['nnorwitz', 'fidoman', 'ajaksu2', 'aptshansen']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'closed'
superseder = '1682942'
type = 'enhancement'
url = 'https://bugs.python.org/issue1165404'
versions = ['Python 2.7']

[fidoman]

ConfigParser is module which parses commonly used
INI files. It gets sections from file and values from
sections. By now, it gets from file key and value divided
by symbol ":" or "=".

For FTN application, a want to use FTN addresses as
keys. FTN address looks like "2:5020/12000". So if I try
to use it as key, ConfigParser considers "2" as key
and "5020/12000 = ..." as value.

I made patch, which allows to use any set of symbols
(or '=' and ':' by default for compatibility) as delimitier
between key and value in INI file.

[nnorwitz]

Note: delimmap doesn't look like it's needed. Should be able to just check if vi in self.delim. (Although I'm kinda tired and don't feel like thinking too hard, so maybe that's just bs.).

[aptshansen]

I think the basis of this patch is a good one; I think 'delimiter' should be plural as delimiters, but that might be all picky. :)

I don't think "self.delimmap = map(lambda x: x, self.delim)" should be done; map and lambda aren't needed here. Wouldn't it be cleaner to just accept a list and join it instead? More Pythonic? Since delimiter=":=" to me looks like you want the string ":=" to be a delimiter, but I might be having pascal flashbacks. To me its more clear.

E.g.:

def __init__(self, defaults=None, delimiters=(':', '=')):
    self._delimiters = ''.join(delimiters)

As stated below, you don't need delimmap; "if vi in self.delim" will work fine.

Anyways, all that aside (and that's just opinions, but--):

1. The patch no longer applies cleanly to the HEAD. I believe it would be very straightforward to fix the patch up though.
2. It needs documentation, and
3. It definitely needs tests added to test_cfgparser.

[aptshansen]

It actually turns out this patch would make *my* life easier, so instead of leaving it to the original submitter to make current and add stuff to, I modified it and added docs and tests as 1682942.

[devdanzin]

Closing as bpo-1682942 has a better patch (a link to this one is
automagically added).