ZipFile __del__/close problem with longint/long files

[kxroberto]

BPO	1182788
Nosy	@amauryfa

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-08-21.16:19:22.170>
created_at = <Date 2005-04-14.08:10:03.000>
labels = ['type-bug', 'library']
title = 'ZipFile __del__/close problem with longint/long files'
updated_at = <Date 2010-08-21.16:19:22.137>
user = 'https://bugs.python.org/kxroberto'

bugs.python.org fields:

activity = <Date 2010-08-21.16:19:22.137>
actor = 'amaury.forgeotdarc'
assignee = 'none'
closed = True
closed_date = <Date 2010-08-21.16:19:22.170>
closer = 'amaury.forgeotdarc'
components = ['Library (Lib)']
creation = <Date 2005-04-14.08:10:03.000>
creator = 'kxroberto'
dependencies = []
files = []
hgrepos = []
issue_num = 1182788
keywords = []
message_count = 4.0
messages = ['60727', '60728', '60729', '114505']
nosy_count = 3.0
nosy_names = ['amaury.forgeotdarc', 'alanmcintyre', 'kxroberto']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'test needed'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1182788'
versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']

[kxroberto]

From a user (py2.3.4 based app) I got only this small
trace:
I cannot reproduce it easily:

--- sync complete: 6 files (0+6), 3488210kB copied.
--- 1795.9 Seconds (100.0% CPU Time)
Exception exceptions.OverflowError: 'long int too
large to convert to int' in <bound method
ZipFile.__del__ of <zipfile.ZipFile instance at
0x009D9D50>> ignored

[alanmcintyre]

Logged In: YES
user_id=1115903

How do you reproduce it? I have seen that exception pop up
when trying to add a file >2GB to an archive (although in
that case it occurred during the call to ZipFile.write
rather than __del__). It looks to me like writing the
end-of-zip-archive record - during close(), which is called
by __del__() - would give this exception if the contents of
the archive were > 2GB, but I haven't tried this out to be
sure. If that's what's causing the problem, then it would
appear to me that it's just a limitation of the ZIP file
format, but maybe the ZipFile object could detect this and
raise a less cryptic exception.

[alanmcintyre]

Logged In: YES
user_id=1115903

Oh, silly me, I didn't notice this: "3488210kB copied,"
which is of course >2GB (don't know if your number indicates
pre- or post-compression though). I'm assuming this means
that you're bumping into the limits of the zip file format.

Since this sort of thing happens occasionally in some
applications I maintain, I will look at making a patch for
ZipFile that will at least tell you when you exceed file
format limits (either individual file size or total archive
file size).

[amauryfa]

At the time, zipfile.py did not support the ZIP64 format...