bdist_rpm still can't handle dashes in versions

[sarynx]

BPO	1360200
Nosy	@loewis
Files	bdist_rpm-dashed-versions.patch: patch which fixes bdist_rpm to handle versions with dashes properly

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2006-11-12.18:56:52.000>
created_at = <Date 2005-11-18.15:41:43.000>
labels = ['library']
title = "bdist_rpm still can't handle dashes in versions"
updated_at = <Date 2006-11-12.18:56:52.000>
user = 'https://bugs.python.org/sarynx'

bugs.python.org fields:

activity = <Date 2006-11-12.18:56:52.000>
actor = 'loewis'
assignee = 'jafo'
closed = True
closed_date = None
closer = None
components = ['Distutils']
creation = <Date 2005-11-18.15:41:43.000>
creator = 'sarynx'
dependencies = []
files = ['6883']
hgrepos = []
issue_num = 1360200
keywords = ['patch']
message_count = 4.0
messages = ['49071', '49072', '49073', '49074']
nosy_count = 4.0
nosy_names = ['loewis', 'nnorwitz', 'jafo', 'sarynx']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1360200'
versions = ['Python 2.6']

[sarynx]

I tried to use Python 2.4.2 to create a bdist_rpm of
setuptools, whose version string was 0.6a9dev-r41475.
The distutils/command/bdist_rpm module's
_make_spec_file method mangled the version to
0.6a9dev_r41475 (line 370). Then when the spec file was
being built by rpmbuild, it looked for the sdist named
setuptools-0.6a9dev_r41475.tar.gz, which didn't exist:
it was called setuptools-0.6a9dev-r41475.tar.gz (note
dash).

So you have to mangle the version to make rpm happy -
but you can't expect the sdist to have the mangled
version as part of its name.

I looked at the nightly Python source as of 17 Nov 2005
and saw that this bug still exists in the development
version of Python.

A patch is attached which fixed this bug for me.

[nnorwitz]

Logged In: YES
user_id=33168

Sean, you seem to know a lot more about rpms than most of
us. Any comment on this approach?

[jafo]

Logged In: YES
user_id=81797

This patch looks good to me. I checked in python-trunk and
it still seems to need to be fixed. I'd recommend it gets
checked in for the 2.6 release. I'd like one of the
distutils people to confirm this though.

[loewis]

Logged In: YES
user_id=21627

Thanks for the patch. Committed as r52741 and r52742