distutils.filelist.glob_to_re fails

[WayneD]

BPO	1491431
Nosy	@tarekziade

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tarekziade'
closed_at = <Date 2009-04-05.21:52:36.149>
created_at = <Date 2006-05-19.07:55:00.000>
labels = ['type-bug', 'library']
title = 'distutils.filelist.glob_to_re fails'
updated_at = <Date 2009-04-05.21:52:36.116>
user = 'https://bugs.python.org/wayned'

bugs.python.org fields:

activity = <Date 2009-04-05.21:52:36.116>
actor = 'tarek'
assignee = 'tarek'
closed = True
closed_date = <Date 2009-04-05.21:52:36.149>
closer = 'tarek'
components = ['Distutils', 'Library (Lib)']
creation = <Date 2006-05-19.07:55:00.000>
creator = 'wayned'
dependencies = []
files = []
hgrepos = []
issue_num = 1491431
keywords = []
message_count = 2.0
messages = ['60915', '85573']
nosy_count = 2.0
nosy_names = ['tarek', 'wayned']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'test needed'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1491431'
versions = ['Python 2.6', 'Python 3.0', 'Python 3.1', 'Python 2.7']

[WayneD]

The regex substitution in distutils.filelist.glob_to_re
fails to do the right thing in a couple cases:

1. it fails to translate a dot after an even number of
   backslashes.

2. it fails to translate multiple dots in row.

For example:

foo\\* -> foo\\.*$
foo???? -> foo[^/].[^/].$

The following substitution fixes these problems:

re.sub(r'((?<!\\)(\\\\)*)\.', r'\1[^/]', re_pattern)

This allows the dot to be preceeded by an even number
of backslashes (including 0) and it utilizes a negative
look-behind assertion so that adjacent dots are handled.

This problem is present in the svn code, and appears to
be identical in versions 2.4.2 and 2.3.5 (the only two
versions I had around to check).

[tarekziade]

fixed in r71280 and r71284
backported in r71281 and r71285