Fix for #1513611 and #1511497; xml.sax imports

[zseil]

BPO	1519796
Nosy	@loewis, @freddrake
Files	sax_relative_imports.diff: patch against trunk revision 50508 test_xml_importing.py: unittests sax_relative_imports_updated.diff test_xml_importing_updated.py: updated unittests sax-test-cases.diff: unit tests that exercise both issues

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/freddrake'
closed_at = <Date 2006-07-27.12:48:38.000>
created_at = <Date 2006-07-10.07:32:09.000>
labels = ['expert-XML', 'invalid']
title = 'Fix for python/cpython#43562 and python/cpython#43542; xml.sax imports'
updated_at = <Date 2006-07-27.12:48:38.000>
user = 'https://bugs.python.org/zseil'

bugs.python.org fields:

activity = <Date 2006-07-27.12:48:38.000>
actor = 'zseil'
assignee = 'fdrake'
closed = True
closed_date = None
closer = None
components = ['XML']
creation = <Date 2006-07-10.07:32:09.000>
creator = 'zseil'
dependencies = []
files = ['7380', '7381', '7382', '7383', '7384']
hgrepos = []
issue_num = 1519796
keywords = ['patch']
message_count = 5.0
messages = ['50640', '50641', '50642', '50643', '50644']
nosy_count = 3.0
nosy_names = ['loewis', 'fdrake', 'zseil']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1519796'
versions = ['Python 2.5']

[zseil]

Package xmlcore.sax currently uses a mix of realtive
and absolute imports. This caused the following bugs:
http://python.org/sf/1513611
http://python.org/sf/1511497

This patch fixes it, by using relative imports.
I tried using absolute imports, but then some of
the tests in the attached test_xml_importing
module fail.

The tests are separate because I don't know how
to include setUp() and tearDown() methods into
non unittest based tests.

[zseil]

Logged In: YES
user_id=1326842

Attaching a new patch and updated tests, since I missed
that make_parser() uses __import__().

[loewis]

Logged In: YES
user_id=21627

Assigning to Fred Drake, who introduced xmlcore.

[freddrake]

Logged In: YES
user_id=3066

These tests do not trigger any failures for me with the
current trunk, so I'm not sure what the patch is fixing.

I'm attaching a patch that includes tests cases for both of
the issues reportedly fixed by this patch.

[zseil]

Logged In: YES
user_id=1326842

The patch is extremely fragile and works only if you don't
mix objects from xml and xmlcore. As your test shows, it
breaks if you import 'make_parser' and 'SAXParseException'
from different packages.

As for the tests, the first four fail for me if I run them
as a script. They are not integrated into the test suite
since they are missing a test_main() function.

It seems that renaming xmlcore back to xml is the simplest
solution, so I'll just close this patch.